From 90328cfa394d9a9c5a3e807f3fc7ae7f7e41499e Mon Sep 17 00:00:00 2001 From: Rowan Manning Date: Mon, 25 Apr 2016 21:17:03 +0100 Subject: [PATCH] Fix JSHint errors --- .jscsrc | 3 +-- .jshintignore | 3 +-- app.js | 8 ++++---- route/task/delete.js | 7 +++---- route/task/edit.js | 1 - route/task/ignore.js | 4 ---- route/task/run.js | 8 ++++---- route/task/unignore.js | 4 ---- test/integration/helper/webservice.js | 8 ++++---- test/integration/route/index.js | 8 +++----- test/integration/route/new.js | 8 +++----- test/integration/route/result/download.js | 8 +++----- test/integration/route/result/index.js | 8 +++----- test/integration/route/task/delete.js | 8 +++----- test/integration/route/task/edit.js | 9 +++------ test/integration/route/task/index.js | 8 +++----- test/integration/route/task/run.js | 8 +++----- test/integration/setup.js | 2 -- view/presenter/task.js | 7 +++---- 19 files changed, 44 insertions(+), 76 deletions(-) diff --git a/.jscsrc b/.jscsrc index d5100db..459ec7e 100644 --- a/.jscsrc +++ b/.jscsrc @@ -83,7 +83,6 @@ "excludeFiles": [ "coverage", "node_modules", - "public/js/site.min.js", - "public/js/vendor" + "public/js" ] } diff --git a/.jshintignore b/.jshintignore index 0ccb3ce..0fd4831 100644 --- a/.jshintignore +++ b/.jshintignore @@ -1,4 +1,3 @@ coverage node_modules -public/js/site.min.js -public/js/vendor +public/js diff --git a/app.js b/app.js index 486cbe0..c42e1a0 100644 --- a/app.js +++ b/app.js @@ -1,15 +1,15 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . @@ -29,7 +29,7 @@ function initApp (config, callback) { config = defaultConfig(config); var webserviceUrl = config.webservice; - if (typeof webserviceUrl == 'object') { + if (typeof webserviceUrl === 'object') { webserviceUrl = 'http://' + webserviceUrl.host + ':' + webserviceUrl.port + '/'; } diff --git a/route/task/delete.js b/route/task/delete.js index dd60087..6ef8422 100644 --- a/route/task/delete.js +++ b/route/task/delete.js @@ -1,21 +1,20 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . 'use strict'; -var _ = require('underscore'); var presentTask = require('../../view/presenter/task'); module.exports = route; diff --git a/route/task/edit.js b/route/task/edit.js index 0f426a6..c880bf6 100644 --- a/route/task/edit.js +++ b/route/task/edit.js @@ -15,7 +15,6 @@ 'use strict'; -var _ = require('underscore'); var presentTask = require('../../view/presenter/task'); var getStandards = require('../../data/standards'); diff --git a/route/task/ignore.js b/route/task/ignore.js index d6b79c6..084ef59 100644 --- a/route/task/ignore.js +++ b/route/task/ignore.js @@ -1,9 +1,5 @@ 'use strict'; -var _ = require('underscore'); -var presentTask = require('../../view/presenter/task'); -var getStandards = require('../../data/standards'); - module.exports = route; // Route definition diff --git a/route/task/run.js b/route/task/run.js index 493956b..5b82341 100644 --- a/route/task/run.js +++ b/route/task/run.js @@ -1,15 +1,15 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . @@ -21,7 +21,7 @@ module.exports = route; function route (app) { app.express.get('/:id/run', function (req, res, next) { - app.webservice.task(req.params.id).run(function (err, task) { + app.webservice.task(req.params.id).run(function (err) { if (err) { return next(); } diff --git a/route/task/unignore.js b/route/task/unignore.js index aedd497..1ed6b81 100644 --- a/route/task/unignore.js +++ b/route/task/unignore.js @@ -1,9 +1,5 @@ 'use strict'; -var _ = require('underscore'); -var presentTask = require('../../view/presenter/task'); -var getStandards = require('../../data/standards'); - module.exports = route; // Route definition diff --git a/test/integration/helper/webservice.js b/test/integration/helper/webservice.js index 51cce38..94c4903 100644 --- a/test/integration/helper/webservice.js +++ b/test/integration/helper/webservice.js @@ -1,15 +1,15 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . @@ -22,7 +22,7 @@ module.exports = createWebserviceClient; // Create a webservice client function createWebserviceClient (config) { var webserviceUrl = config.webservice; - if (typeof webserviceUrl == 'object') { + if (typeof webserviceUrl === 'object') { webserviceUrl = 'http://' + webserviceUrl.host + ':' + webserviceUrl.port + '/'; } return createClient(webserviceUrl); diff --git a/test/integration/route/index.js b/test/integration/route/index.js index 4c69ed4..bda0ff9 100644 --- a/test/integration/route/index.js +++ b/test/integration/route/index.js @@ -1,20 +1,18 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . -/* global beforeEach, describe, it */ -/* jshint maxlen: false, maxstatements: false */ 'use strict'; var assert = require('proclaim'); diff --git a/test/integration/route/new.js b/test/integration/route/new.js index 06fea7f..dbb9088 100644 --- a/test/integration/route/new.js +++ b/test/integration/route/new.js @@ -1,20 +1,18 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . -/* global beforeEach, describe, it */ -/* jshint maxlen: false, maxstatements: false */ 'use strict'; var assert = require('proclaim'); diff --git a/test/integration/route/result/download.js b/test/integration/route/result/download.js index 481a384..0a6a37b 100644 --- a/test/integration/route/result/download.js +++ b/test/integration/route/result/download.js @@ -1,20 +1,18 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . -/* global beforeEach, describe, it */ -/* jshint maxlen: false, maxstatements: false */ 'use strict'; var assert = require('proclaim'); diff --git a/test/integration/route/result/index.js b/test/integration/route/result/index.js index 8dfced1..a605dc1 100644 --- a/test/integration/route/result/index.js +++ b/test/integration/route/result/index.js @@ -1,20 +1,18 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . -/* global beforeEach, describe, it */ -/* jshint maxlen: false, maxstatements: false */ 'use strict'; var assert = require('proclaim'); diff --git a/test/integration/route/task/delete.js b/test/integration/route/task/delete.js index c38df8a..fcb3f9f 100644 --- a/test/integration/route/task/delete.js +++ b/test/integration/route/task/delete.js @@ -1,20 +1,18 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . -/* global beforeEach, describe, it */ -/* jshint maxlen: false, maxstatements: false */ 'use strict'; var assert = require('proclaim'); diff --git a/test/integration/route/task/edit.js b/test/integration/route/task/edit.js index 0d38f34..169db33 100644 --- a/test/integration/route/task/edit.js +++ b/test/integration/route/task/edit.js @@ -1,20 +1,18 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . -/* global beforeEach, describe, it */ -/* jshint maxlen: false, maxstatements: false */ 'use strict'; var assert = require('proclaim'); @@ -132,4 +130,3 @@ describe('POST //edit', function () { }); }); - diff --git a/test/integration/route/task/index.js b/test/integration/route/task/index.js index 6159d74..39a1fde 100644 --- a/test/integration/route/task/index.js +++ b/test/integration/route/task/index.js @@ -1,20 +1,18 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . -/* global beforeEach, describe, it */ -/* jshint maxlen: false, maxstatements: false */ 'use strict'; var assert = require('proclaim'); diff --git a/test/integration/route/task/run.js b/test/integration/route/task/run.js index 2b5fc30..12d4d9f 100644 --- a/test/integration/route/task/run.js +++ b/test/integration/route/task/run.js @@ -1,20 +1,18 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . -/* global beforeEach, describe, it */ -/* jshint maxlen: false, maxstatements: false */ 'use strict'; var assert = require('proclaim'); diff --git a/test/integration/setup.js b/test/integration/setup.js index 1e4e935..9904a6c 100644 --- a/test/integration/setup.js +++ b/test/integration/setup.js @@ -13,8 +13,6 @@ // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . -/* global afterEach, before */ -/* jshint maxlen: false, maxstatements: false */ 'use strict'; var config = require('../../config/test.json'); diff --git a/view/presenter/task.js b/view/presenter/task.js index dc87f24..76e216e 100644 --- a/view/presenter/task.js +++ b/view/presenter/task.js @@ -1,21 +1,20 @@ // This file is part of pa11y-dashboard. -// +// // pa11y-dashboard is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. -// +// // pa11y-dashboard is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. -// +// // You should have received a copy of the GNU General Public License // along with pa11y-dashboard. If not, see . 'use strict'; -var _ = require('underscore'); var presentIgnoreRules = require('./ignore'); var presentResult = require('./result');