Display the ignore rules for results, not tasks

This commit is contained in:
Rowan Manning
2013-12-11 14:06:51 +00:00
parent c8b97df4ee
commit 917057a109
3 changed files with 28 additions and 8 deletions

View File

@@ -25,7 +25,7 @@
"express": "~3.4", "express": "~3.4",
"express-hbs": "~0.2", "express-hbs": "~0.2",
"moment": "~2.2", "moment": "~2.2",
"pa11y-webservice": "~1.2", "pa11y-webservice": "~1.3",
"pa11y-webservice-client-node": "~1.1", "pa11y-webservice-client-node": "~1.1",
"underscore": "~1.5" "underscore": "~1.5"
}, },

View File

@@ -89,21 +89,21 @@
<p class="heading label-info" id="notices">Well done! You have 0 notices. <span class="glyphicon glyphicon-ok pull-right"></span></p> <p class="heading label-info" id="notices">Well done! You have 0 notices. <span class="glyphicon glyphicon-ok pull-right"></span></p>
{{/if}} {{/if}}
{{#if task.ignore.length}} {{#if mainResult.ignore.length}}
<div class="heading label-default"> <div class="heading label-default">
<span data-role="expander" class="pull-right expander"> + </span> <span data-role="expander" class="pull-right expander"> + </span>
Ignored Rules ( {{task.ignore.length}} ) Ignored Rules ( {{mainResult.ignore.length}} )
</div> </div>
<div class="task-default tasks-list collapse clearfix"> <div class="task-default tasks-list collapse clearfix">
<ul class="list-unstyled"> <ul class="list-unstyled">
{{#task.ignore}} {{#mainResult.ignore}}
<li> <li>
<p class="crunch rule-name">{{name}}</p> <p class="crunch rule-name">{{name}}</p>
{{#if description}} {{#if description}}
<p>{{description}}</p> <p>{{description}}</p>
{{/if}} {{/if}}
</li> </li>
{{/task.ignore}} {{/mainResult.ignore}}
</ul> </ul>
<a class="pull-right" href="#top" data-role="top">Back to top</a> <a class="pull-right" href="#top" data-role="top">Back to top</a>
</div> </div>

View File

@@ -1,6 +1,8 @@
'use strict'; 'use strict';
var _ = require('underscore'); var _ = require('underscore');
var standardsArray = require('../../data/standards')();
var rules = createStandardDescriptionMap(standardsArray);
module.exports = presentResult; module.exports = presentResult;
@@ -14,6 +16,14 @@ function presentResult (result) {
// Parse date // Parse date
result.date = new Date(result.date); result.date = new Date(result.date);
// Enhance the ignored rules
result.ignore = result.ignore.map(function (name) {
return {
name: name,
description: rules[name]
};
});
// Split out message types // Split out message types
if (result.results) { if (result.results) {
var groupedByType = _.groupBy(result.results, 'type'); var groupedByType = _.groupBy(result.results, 'type');
@@ -31,3 +41,13 @@ function presentResult (result) {
return result; return result;
} }
function createStandardDescriptionMap (standards) {
var map = {};
standards.forEach(function (standard) {
standard.rules.forEach(function (rule) {
map[rule.name] = rule.description;
});
});
return map;
}