Version 1.2.3

Conflicts:
	public/css/site.min.css

CONTRIBUTING.md

@@ -31,8 +31,23 @@ Coding Guidelines
 * Don't commit code without passing tests (run `grunt test`).
 
 
+Versioning
+----------
+
+We use [Semantic Versioning][semver] in this project. The process for releasing a new version is as follows; this should only be done by core contributors – you don't need to include a tagged version in your pull-requests.
+
+* Switch to `master` and merge the `develop` branch into it
+* Update the version number in `package.json` and `README.md`
+* Commit the changes with the message: "Version x.x.x" (x.x.x being the new version number)
+* Tag the commit with the version number (just the numbers, no "version" or "v")
+* Push with tags: `git push --tags`
+* Check out the `develop` branch, merge `master` into it, and push
+* On GitHub, add [release notes][release-notes] for the new version. The title should be "Version x.x.x", and the description should be a list of new features/fixes
+
 
 [bugs]: https://github.com/nature/pa11y-dashboard/issues?labels=bug&state=open
 [ready]: https://github.com/nature/pa11y-dashboard/issues?labels=ready&state=open
 [issues]: https://github.com/nature/pa11y-dashboard/issues
 [milestones]: https://github.com/nature/pa11y-dashboard/issues/milestones
+[release-notes]: https://github.com/nature/pa11y-dashboard/releases
+[semver]: http://semver.org/

README.md

@@ -3,7 +3,7 @@ pa11y-dashboard
 
 pa11y-dashboard is a web interface to the [pa11y][pa11y] accessibility reporter; allowing you to focus on *fixing* issues rather than hunting them down.
 
-**Current Version:** *1.2.0*  
+**Current Version:** *1.2.3*  
 **Build Status:** [![Build Status][travis-img]][travis]  
 **Node Version Support:** *0.10*
 

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pa11y-dashboard",
-	"version": "1.2.0",
+	"version": "1.2.3",
 	"private": true,
 
 	"description": "pa11y-dashboard is a visual web interface to the pa11y accessibility reporter",

public/less/ie8and.less

@@ -0,0 +1,93 @@
+// Making up for the non support of IE8 and IE7 in Bootstrap 3
+
+// Amend the width of container if you want to here
+@container-md-ie8: @container-md;
+
+@grid-adjustment: percentage(@grid-gutter-width / @container-md-ie8);
+
+.ie7, .ie8 {
+	* {
+		box-sizing: content-box;
+	}
+	.clearfix {
+	    *zoom: 1;
+	}
+	ul, ol {
+		margin-left:0;
+	}
+
+	.container {
+		width: @container-md-ie8;
+	}
+
+	.col-md-1,
+	.col-md-2,
+	.col-md-3,
+	.col-md-4,
+	.col-md-5,
+	.col-md-6,
+	.col-md-7,
+	.col-md-8,
+	.col-md-9,
+	.col-md-10,
+	.col-md-11 {
+		float: left;
+	}
+	.col-md-1  { width: percentage((1 / @grid-columns)) - @grid-adjustment; }
+	.col-md-2  { width: percentage((2 / @grid-columns)) - @grid-adjustment; }
+	.col-md-3  { width: percentage((3 / @grid-columns)) - @grid-adjustment; }
+	.col-md-4  { width: percentage((4 / @grid-columns)) - @grid-adjustment; }
+	.col-md-5  { width: percentage((5 / @grid-columns)) - @grid-adjustment; }
+	.col-md-6  { width: percentage((6 / @grid-columns)) - @grid-adjustment; }
+	.col-md-7  { width: percentage((7 / @grid-columns)) - @grid-adjustment; }
+	.col-md-8  { width: percentage((8 / @grid-columns)) - @grid-adjustment; }
+	.col-md-9  { width: percentage((9 / @grid-columns)) - @grid-adjustment; }
+	.col-md-10 { width: percentage((10/ @grid-columns)) - @grid-adjustment; }
+	.col-md-11 { width: percentage((11/ @grid-columns)) - @grid-adjustment; }
+	.col-md-12 { width: 100% - @grid-adjustment; }
+
+	// Push and pull columns for source order changes
+	.col-md-push-0  { left: auto; }
+	.col-md-push-1  { left: percentage((1 / @grid-columns)); }
+	.col-md-push-2  { left: percentage((2 / @grid-columns)); }
+	.col-md-push-3  { left: percentage((3 / @grid-columns)); }
+	.col-md-push-4  { left: percentage((4 / @grid-columns)); }
+	.col-md-push-5  { left: percentage((5 / @grid-columns)); }
+	.col-md-push-6  { left: percentage((6 / @grid-columns)); }
+	.col-md-push-7  { left: percentage((7 / @grid-columns)); }
+	.col-md-push-8  { left: percentage((8 / @grid-columns)); }
+	.col-md-push-9  { left: percentage((9 / @grid-columns)); }
+	.col-md-push-10 { left: percentage((10/ @grid-columns)); }
+	.col-md-push-11 { left: percentage((11/ @grid-columns)); }
+
+	.col-md-pull-0  { right: auto; }
+	.col-md-pull-1  { right: percentage((1 / @grid-columns)); }
+	.col-md-pull-2  { right: percentage((2 / @grid-columns)); }
+	.col-md-pull-3  { right: percentage((3 / @grid-columns)); }
+	.col-md-pull-4  { right: percentage((4 / @grid-columns)); }
+	.col-md-pull-5  { right: percentage((5 / @grid-columns)); }
+	.col-md-pull-6  { right: percentage((6 / @grid-columns)); }
+	.col-md-pull-7  { right: percentage((7 / @grid-columns)); }
+	.col-md-pull-8  { right: percentage((8 / @grid-columns)); }
+	.col-md-pull-9  { right: percentage((9 / @grid-columns)); }
+	.col-md-pull-10 { right: percentage((10/ @grid-columns)); }
+	.col-md-pull-11 { right: percentage((11/ @grid-columns)); }
+
+	// Offsets
+	.col-md-offset-0  { margin-left: 0; }
+	.col-md-offset-1  { margin-left: percentage((1 / @grid-columns)); }
+	.col-md-offset-2  { margin-left: percentage((2 / @grid-columns)); }
+	.col-md-offset-3  { margin-left: percentage((3 / @grid-columns)); }
+	.col-md-offset-4  { margin-left: percentage((4 / @grid-columns)); }
+	.col-md-offset-5  { margin-left: percentage((5 / @grid-columns)); }
+	.col-md-offset-6  { margin-left: percentage((6 / @grid-columns)); }
+	.col-md-offset-7  { margin-left: percentage((7 / @grid-columns)); }
+	.col-md-offset-8  { margin-left: percentage((8 / @grid-columns)); }
+	.col-md-offset-9  { margin-left: percentage((9 / @grid-columns)); }
+	.col-md-offset-10 { margin-left: percentage((10/ @grid-columns)); }
+	.col-md-offset-11 { margin-left: percentage((11/ @grid-columns)); }
+
+	.clearfix {
+	    *zoom: 1;
+	}
+}

public/less/main.less

@@ -58,4 +58,5 @@
 @import "site-responsive.less";
 
 // Stupid ie
+@import "ie8and.less";
 @import "site-ie8and.less";

public/less/site-ie8and.less

@@ -1,75 +1,5 @@
 // Making up for the non support of IE8 and IE7 in Bootstrap 3
 .ie7, .ie8 {
-	.container {
-		width: @container-md;
-	}
-	.col-md-1,
-	.col-md-2,
-	.col-md-3,
-	.col-md-4,
-	.col-md-5,
-	.col-md-6,
-	.col-md-7,
-	.col-md-8,
-	.col-md-9,
-	.col-md-10,
-	.col-md-11 {
-		float: left;
-	}
-	.col-md-1  { width: percentage((1 / @grid-columns)); }
-	.col-md-2  { width: percentage((2 / @grid-columns)); }
-	.col-md-3  { width: percentage((3 / @grid-columns)); }
-	.col-md-4  { width: percentage((4 / @grid-columns)); }
-	.col-md-5  { width: percentage((5 / @grid-columns)); }
-	.col-md-6  { width: percentage((6 / @grid-columns)); }
-	.col-md-7  { width: percentage((7 / @grid-columns)); }
-	.col-md-8  { width: percentage((8 / @grid-columns)); }
-	.col-md-9  { width: percentage((9 / @grid-columns)); }
-	.col-md-10 { width: percentage((10/ @grid-columns)); }
-	.col-md-11 { width: percentage((11/ @grid-columns)); }
-	.col-md-12 { width: 100%; }
-
-	// Push and pull columns for source order changes
-	.col-md-push-0  { left: auto; }
-	.col-md-push-1  { left: percentage((1 / @grid-columns)); }
-	.col-md-push-2  { left: percentage((2 / @grid-columns)); }
-	.col-md-push-3  { left: percentage((3 / @grid-columns)); }
-	.col-md-push-4  { left: percentage((4 / @grid-columns)); }
-	.col-md-push-5  { left: percentage((5 / @grid-columns)); }
-	.col-md-push-6  { left: percentage((6 / @grid-columns)); }
-	.col-md-push-7  { left: percentage((7 / @grid-columns)); }
-	.col-md-push-8  { left: percentage((8 / @grid-columns)); }
-	.col-md-push-9  { left: percentage((9 / @grid-columns)); }
-	.col-md-push-10 { left: percentage((10/ @grid-columns)); }
-	.col-md-push-11 { left: percentage((11/ @grid-columns)); }
-
-	.col-md-pull-0  { right: auto; }
-	.col-md-pull-1  { right: percentage((1 / @grid-columns)); }
-	.col-md-pull-2  { right: percentage((2 / @grid-columns)); }
-	.col-md-pull-3  { right: percentage((3 / @grid-columns)); }
-	.col-md-pull-4  { right: percentage((4 / @grid-columns)); }
-	.col-md-pull-5  { right: percentage((5 / @grid-columns)); }
-	.col-md-pull-6  { right: percentage((6 / @grid-columns)); }
-	.col-md-pull-7  { right: percentage((7 / @grid-columns)); }
-	.col-md-pull-8  { right: percentage((8 / @grid-columns)); }
-	.col-md-pull-9  { right: percentage((9 / @grid-columns)); }
-	.col-md-pull-10 { right: percentage((10/ @grid-columns)); }
-	.col-md-pull-11 { right: percentage((11/ @grid-columns)); }
-
-	// Offsets
-	.col-md-offset-0  { margin-left: 0; }
-	.col-md-offset-1  { margin-left: percentage((1 / @grid-columns)); }
-	.col-md-offset-2  { margin-left: percentage((2 / @grid-columns)); }
-	.col-md-offset-3  { margin-left: percentage((3 / @grid-columns)); }
-	.col-md-offset-4  { margin-left: percentage((4 / @grid-columns)); }
-	.col-md-offset-5  { margin-left: percentage((5 / @grid-columns)); }
-	.col-md-offset-6  { margin-left: percentage((6 / @grid-columns)); }
-	.col-md-offset-7  { margin-left: percentage((7 / @grid-columns)); }
-	.col-md-offset-8  { margin-left: percentage((8 / @grid-columns)); }
-	.col-md-offset-9  { margin-left: percentage((9 / @grid-columns)); }
-	.col-md-offset-10 { margin-left: percentage((10/ @grid-columns)); }
-	.col-md-offset-11 { margin-left: percentage((11/ @grid-columns)); }
-
 	.legend {
 		display: block;
 		width: 100%;
@@ -83,9 +13,6 @@
 	.tooltip-inner {
 		background-color: #000000;
 	}
-	.clearfix {
-	    *zoom: 1;
-	}
 	.date {
 		font-size:85%;
 	}
@@ -98,34 +25,30 @@
 	.stat-type {
 		font-size:floor(@font-size-base * 0.65); // ~10px;
 	}
+	.aside .action-buttons .btn {
+		width:79%;
+	}
+	.pull-right.dropdown-menu {
+		right:134px;
+	}
+	.run-details .pull-right.dropdown-menu {
+		right:64px;
+	}
+	.date-selector .btn-full-width {
+		width:90%;
+	}
 }
 
 .ie7 {
-	ul {
-		margin-left:0;
-	}
-	.col-md-2 { width:14%; }
-	.col-md-3 { width:22%; }
-	.col-md-4  {
-		width: 32%;
-		padding:0 5px;
-	}
-	.col-md-9 { width:72%; }
-	.col-md-10 { width:80%; } 
-	.col-md-12 { width: 97%; }
-
 	.aside .task-stats li {
 		width:31.5%;
 	}
-	.aside .action-buttons .btn {
-		width:79%;
-	}
 	.date-selector {
 		zoom:1;
 	}
 	.zfix {
 		position:relative;
-		z-index:100;
+		z-index:1001;
 	}
 	.list-group li .list-group-item {
 		margin:0;
@@ -137,5 +60,24 @@
 	}
 	.date-selector {
 		margin-top:-155px;
+
+		.btn-full-width {
+			width:100%;
+		}
+	}
+	.sr-only {
+		position:relative;
+	}
+	.breadcrumb li {
+		vertical-align: top;
+		zoom: 1;
+		display: inline;
+		margin-right:10px;
+	}
+	.pull-right.dropdown-menu {
+		right:0px;
+	}
+	.run-details .pull-right.dropdown-menu {
+		right:82px;
 	}
 }

public/less/site.less

@@ -70,7 +70,7 @@
 }
 .dropdown-toggle {
 	margin-top:0;
-	margin-bottom:10px;
+	margin-bottom:5px;
 }
 .list-group {
 	li .list-group-item {
@@ -238,6 +238,9 @@
 	h2 {
 		word-wrap:break-word;
 	}
+	.h4 {
+		margin-bottom:22px;
+	}
 }
 .date {
 	margin-top:5px;
@@ -320,7 +323,7 @@ ul.date-links {
 	}
 
 	&.single-result {
-		margin-top:-55px;
+		margin-top:-52px;
 
 		.show-stats {
 			display:none;

route/result/download.js

@@ -46,13 +46,13 @@ function route (app) {
     app.express.get('/:id/:rid.csv', getTaskAndResult, function (req, res) {
         var task = res.locals.task;
         var result = res.locals.result;
-        var rows = ['"code", "message", "type"'];
+        var rows = ['"code","message","type"'];
         result.results.forEach(function (msg) {
             rows.push([
                 JSON.stringify(msg.code),
                 JSON.stringify(msg.message),
                 JSON.stringify(msg.type)
-            ].join(', '));
+            ].join(','));
         });
         res.attachment(getDownloadFileName(task, result, 'csv'));
         res.send(rows.join('\n'));

test/functional/route/result/download.js

@@ -20,7 +20,7 @@ describe('GET /<task-id>/<result-id>.csv', function () {
 	});
 
 	it('should output CSV results', function () {
-		assert.match(this.last.body, /^"code", "message", "type"/);
+		assert.match(this.last.body, /^"code","message","type"/);
 	});
 
 });

view/partial/task-header.html

@@ -1,4 +1,4 @@
-<div class="col-md-12">
+<div class="col-md-12 zfix">
 	<div class="ruled task-header">
 		<div class="row clearfix">
 			<div class="col-md-9 col-sm-9">